Account for per-job output storage for budget estimations#4682
Open
chrisvanrun wants to merge 8 commits into
Open
Account for per-job output storage for budget estimations#4682chrisvanrun wants to merge 8 commits into
chrisvanrun wants to merge 8 commits into
Conversation
chrisvanrun
commented
Apr 23, 2026
| challenge_request.compute_and_storage_costs_euros_for_phases[ | ||
| i_phase | ||
| ] | ||
| pytest.approx( |
Member
Author
There was a problem hiding this comment.
This was giving some false positives on differences. So added an approx here as well.
chrisvanrun
commented
Apr 23, 2026
| @@ -1601,15 +1626,35 @@ def total_compute_time(self): | |||
|
|
|||
| @cached_property | |||
| def data_storage_size_gb_for_phases(self): | |||
Member
Author
There was a problem hiding this comment.
Not sure if it was better to split this into input/output. Opted to keep this in a single property for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned here:
This adds an
average_size_job_output_mb_for_tasksas a factor when estimating the required budget.Existing budget estimations have this migrated to be set to zero.
Shown in the table as:
